fix: 🐛 Fixed ToolTip Slide Transition #369

faiyaz-shaikh · 2023-04-06T06:39:24Z

Description

Fixed ToolTip Slide Transition

Added toolTipSlideEndDistance to define motion range for tooltip slide animation.
Added the ToolTipSlideTransition widget and removed SlideTransition to fix the sliding range issue because before sliding range increased as child's size increased

Checklist

The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
I have followed the Contributor Guide when preparing my PR.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation in docs and added dartdoc comments with ///.
I have updated/added relevant examples in examples or docs.

Breaking Change?

Yes, this PR is a breaking change.
No, this PR is not a breaking change.

Related Issues

ujas-m-simformsolutions · 2023-04-07T06:08:16Z

lib/src/tooltip_widget.dart

@@ -589,3 +590,18 @@ class _Arrow extends CustomPainter {
        oldDelegate.strokeWidth != strokeWidth;
  }
 }
+
+class ToolTipSlideTransition extends AnimatedWidget {


This file is getting very big now, can you please saparate code in multiple files.

ujas-m-simformsolutions · 2023-04-12T06:00:29Z

lib/src/tooltip_widget.dart

-                    : const Offset(0.0, 0.100),
+                begin: const Offset(0.0, 0.0),
+                end: Offset(
+                    0.0, widget.movingEndDistance * contentOffsetMultiplier),


ujas-m-simformsolutions · 2023-04-12T06:00:35Z

lib/src/tooltip_widget.dart

-                      top: paddingTop,
-                    ),
+                    padding:
+                        EdgeInsets.only(top: paddingTop, bottom: paddingBottom),


Sahil-Simform · 2024-03-08T11:33:34Z

lib/src/tooltip_widget.dart

-                end: const Offset(0.0, 0.100),
+                begin: const Offset(0.0, 0.0),
+                end: Offset(
+                    0.0, widget.movingEndDistance * contentOffsetMultiplier),


Please reformat this for better readability

aditya-css · 2024-03-08T15:52:27Z

lib/src/showcase.dart

@@ -247,6 +247,13 @@ class Showcase extends StatefulWidget {
  /// Disables barrier interaction for a particular showCase.
  final bool disableBarrierInteraction;

+  /// Define End distance of tooltip position when tooltip is moving.


Please improve wording.

aditya-css · 2024-03-08T15:52:54Z

lib/src/showcase.dart

@@ -247,6 +247,13 @@ class Showcase extends StatefulWidget {
  /// Disables barrier interaction for a particular showCase.
  final bool disableBarrierInteraction;

+  /// Define End distance of tooltip position when tooltip is moving.
+  ///
+  /// Which is from 0 to movingEndDistance (positive)


Please mention it as the motion range for tooltip slide animation.

Also, since it is mentioned positive here, please check with negative value and add assertion of the polarity if positive value is absolutely required.

aditya-css · 2024-03-08T15:53:12Z

lib/src/showcase.dart

@@ -292,6 +299,7 @@ class Showcase extends StatefulWidget {
    this.descriptionTextDirection,
    this.onBarrierClick,
    this.disableBarrierInteraction = false,
+    this.toolTipSlideEndDistance = 7.0,


You can omit the .0.

aditya-css · 2024-03-08T15:55:05Z

lib/src/tooltip_widget.dart

-                end: !widget.showArrow && !isArrowUp
-                    ? const Offset(0.0, 0.0)
-                    : const Offset(0.0, 0.100),
+                begin: const Offset(0.0, 0.0),


You can use Offset.zero here.

aditya-css · 2024-03-08T15:55:55Z

lib/src/widget/tooltip_slide_transition.dart

+
+  @override
+  Widget build(BuildContext context) =>
+      Transform.translate(offset: _progress.value, child: child);


Please improve format for better readability.

aditya-css · 2024-03-08T16:00:14Z

lib/src/widget/tooltip_slide_transition.dart

+
+  final Widget child;
+
+  Animation<Offset> get _progress => listenable as Animation<Offset>;


Since this variable is only used in the build method, you can create it there only instead of this getter.

Ujas-Majithiya

Lgtm

Sahil-Simform

LGTM!

ujas-m-simformsolutions

LGTM

- Added `toolTipSlideEndDistance` to define motion range for tooltip slide animation. - Added `ToolTipSlideTransition` widget and removed `SlideTransition` to fix sliding range issue because before sliding range is increasing as child's size increase

ujas-m-simformsolutions requested changes Apr 7, 2023

View reviewed changes

faiyaz-shaikh force-pushed the fix/tooltip_slide_transition branch from 92e21f5 to 06b81e4 Compare April 7, 2023 09:40

ujas-m-simformsolutions requested changes Apr 12, 2023

View reviewed changes

faiyaz-shaikh force-pushed the fix/tooltip_slide_transition branch from 06b81e4 to 668338a Compare April 13, 2023 07:30

Sahil-Simform requested changes Mar 8, 2024

View reviewed changes

Sahil-Simform force-pushed the fix/tooltip_slide_transition branch 2 times, most recently from 64f8423 to 4ef1d97 Compare March 8, 2024 12:44

aditya-css requested changes Mar 8, 2024

View reviewed changes

Sahil-Simform force-pushed the fix/tooltip_slide_transition branch 7 times, most recently from e76f490 to abdcd00 Compare March 12, 2024 07:00

aditya-css force-pushed the fix/tooltip_slide_transition branch from abdcd00 to 9cc8ebe Compare April 18, 2024 09:12

aditya-css approved these changes Apr 18, 2024

View reviewed changes

aditya-css requested review from ujas-m-simformsolutions and Sahil-Simform April 18, 2024 09:15

Ujas-Majithiya approved these changes Apr 18, 2024

View reviewed changes

Sahil-Simform approved these changes Apr 18, 2024

View reviewed changes

ujas-m-simformsolutions approved these changes Apr 18, 2024

View reviewed changes

aditya-css force-pushed the fix/tooltip_slide_transition branch from 9cc8ebe to ca27e7f Compare April 18, 2024 09:28

aditya-css merged commit 6ed6e03 into master Apr 18, 2024
2 checks passed

aditya-css deleted the fix/tooltip_slide_transition branch April 18, 2024 09:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 🐛 Fixed ToolTip Slide Transition #369

fix: 🐛 Fixed ToolTip Slide Transition #369

faiyaz-shaikh commented Apr 6, 2023 •

edited by Sahil-Simform

Loading

ujas-m-simformsolutions Apr 7, 2023

faiyaz-shaikh Apr 13, 2023

ujas-m-simformsolutions Apr 12, 2023

faiyaz-shaikh Apr 13, 2023

ujas-m-simformsolutions Apr 12, 2023

faiyaz-shaikh Apr 13, 2023

Sahil-Simform Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

aditya-css Mar 8, 2024

Ujas-Majithiya left a comment •

edited

Loading

Sahil-Simform left a comment

ujas-m-simformsolutions left a comment •

edited

Loading


		final Widget child;

		Animation<Offset> get _progress => listenable as Animation<Offset>;

fix: 🐛 Fixed ToolTip Slide Transition #369

fix: 🐛 Fixed ToolTip Slide Transition #369

Conversation

faiyaz-shaikh commented Apr 6, 2023 • edited by Sahil-Simform Loading

Description

Checklist

Breaking Change?

Related Issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ujas-Majithiya left a comment • edited Loading

Choose a reason for hiding this comment

Sahil-Simform left a comment

Choose a reason for hiding this comment

ujas-m-simformsolutions left a comment • edited Loading

Choose a reason for hiding this comment

faiyaz-shaikh commented Apr 6, 2023 •

edited by Sahil-Simform

Loading

Ujas-Majithiya left a comment •

edited

Loading

ujas-m-simformsolutions left a comment •

edited

Loading